-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: check stats healthy by reference #8132
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8132 +/- ##
=======================================
Coverage 77.35% 77.36%
=======================================
Files 471 471
Lines 61318 61338 +20
=======================================
+ Hits 47435 47454 +19
- Misses 10310 10311 +1
Partials 3573 3573
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: nolouch <nolouch@gmail.com>
PTAL @rleungx |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c6d2fb9
|
@nolouch: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…che reset (#8201) ref #7897 #8132 introduced a count reference to ensure the consistency between the root tree and subtrees, however, the reference count was not handled correctly during the cache reset process, which may lead to incorrect reference counts in later heartbeat processing. Signed-off-by: JmPotato <ghzpotato@gmail.com>
What problem does this PR solve?
Issue Number: Close #8131 Ref #7897
What is changed and how does it work?
Check List
Tests
bench config:
Before
After
Release note